linux-kernel - Re: Reference counting of MMC host driver modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49686F0C.7030807@s5r6.in-berlin.de>
Date:	Sat, 10 Jan 2009 10:49:00 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Enrik Berkhan <Enrik.Berkhan@...com>
CC:	David Vrabel <david.vrabel@....com>,
	Pierre Ossman <drzeus-mmc@...eus.cx>,
	linux-kernel@...r.kernel.org
Subject: Re: Reference counting of MMC host driver modules

Enrik Berkhan wrote:
> On Fri, Jan 09, 2009 at 06:20:32PM +0000, David Vrabel wrote:
>> Enrik Berkhan wrote:
>>> I've noticed recently that the MMC/SD block driver does not reference 
>>> count the MMC/SD host driver module that it uses via the MMC/SD core 
>>> layer. Thus, I can rmmod my host driver module while, for example, a 
>>> partition on a SD card is mounted.
>> This is same as removing the card while it's in use.
> 
> I don't think so.
> 
> Being able to remove the card while it is in use is a bug of the
> mechanical interface. Can't be fixed easily.
> 
> Being able to remove the module while it is in use is a bug of the
> software. Can be fixed.

Here is my implementation experience with the issue, concerning the two
FireWire driver stacks which I maintain:

In case of firewire (new FireWire stack), module removal of the
controller driver will trigger removal of all child and grandchild
devices, e.g. sd_shutdown of FireWire HDDs.

This will have the same effect as if the cable of the HDD was pulled.
I don't see a need to prevent this because whoever runs
# modprobe -r firewire-ohci
is supposed to know what he is doing.

But in case of ieee1394 (old FireWire stack), the sbp2 storage driver
calls try_module_get() on the host driver whenever it starts using a
device, and of course module_put() when it is done.  I.e. modprobe -r
ohci1394 is blocked as long as the sbp2 driver is in touch with a
FireWire drive.

I added this at some point because of unclean layering of the ieee1394
stack:  The high-level drivers video1394 and dv1394 do not only depend
on the ieee1394 core driver, but also directly on the ohci1394 low-level
driver.  Now, if somebody runs
# modprobe -r video1394
it would also remove ohci1394 if sbp2 hadn't artificially increased
ohci1394's reference count.

*However*, note that try_module_get() and module_put() don't actually do
what you asked for:  They do _not_ guarantee that the host driver gets
unbound from the MMC (or FireWire...) controller:
You can still do
# echo -n ${ID} > /sys/module/${MODULE}/drivers/${DRIVER}/unbind

So, if somebody asked me to copy my ieee1394/sbp2 safeguard into
firewire/fw-sbp2, I would reject that on the grounds that killing the
connection to the FireWire disk is the *expected result* of
# modprobe -r firewire-ohci
-- 
Stefan Richter
-=====-==--= ---= -=-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/