linux-kernel - Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017 ata_sff_hsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090110135104.3f402b5d@lxorguk.ukuu.org.uk>
Date:	Sat, 10 Jan 2009 13:51:04 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Christian Borntraeger <borntraeger@...ibm.com>,
	Sergei Shtylyov <sshtylyov@...mvista.com>,
	linux-ide@...r.kernel.org, Jeff Garzik <jgarzik@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017
 ata_sff_hsm_move+0x45e/0x750()

On Sat, 10 Jan 2009 08:14:01 -0500
Jeff Garzik <jeff@...zik.org> wrote:

> Christian Borntraeger wrote:
> > Am Samstag 10 Januar 2009 schrieb Alan Cox:
> >>>    That's the typical REQUEST SENSE command with 18-byte data length.
> >> Which means something has become horribly broken in the core libata stack.
> >> An 18 byte inquiry would have 18 bytes as the *last* sg element. That
> >> would therefore not trigger the WARN_ON. Someone has passed an sg list
> >> that isn't properly terminated perhaps ?
> >>
> >> I wonder if the pad code broke this.
> > 
> > I just checked 2.6.28 + PIO32 patch. Its also broken. Whatever caused this 
> > problem did it a while ago.
> 
> Just to be clear, you mean:
> 
> 2.6.28 is OK
> 2.6.28 + PIO32 is broken

As far as I can tell

2.6.28 is broken but it doesn't show due to other factors
2.6.28 using 32bit PIO shows up the fact someone seems to be passing
broken sg lists
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/