[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090110135508.3d54007f@lxorguk.ukuu.org.uk>
Date: Sat, 10 Jan 2009 13:55:08 +0000
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Sergei Shtylyov <sshtylyov@...mvista.com>
Cc: Christian Borntraeger <borntraeger@...ibm.com>,
linux-ide@...r.kernel.org, Jeff Garzik <jgarzik@...hat.com>,
lkml <linux-kernel@...r.kernel.org>
Subject: Re: todays git: WARNING: at drivers/ata/libata-sff.c:1017
ata_sff_hsm_move+0x45e/0x750()
On Sat, 10 Jan 2009 16:01:44 +0300
Sergei Shtylyov <sshtylyov@...mvista.com> wrote:
> Hello.
>
> Alan Cox wrote:
>
> >> That's the typical REQUEST SENSE command with 18-byte data length.
>
> > Which means something has become horribly broken in the core libata stack.
> > An 18 byte inquiry would have 18 bytes as the *last* sg element. That
>
> Did you get me right? 18 bytes is the typical REQUEST SENSE payload
> (libata requested 96 bytes), not INQUIRY. For the INQUIRY 36 bytes was
> requested and received (divisible by 4).
> And I doubt there can be more than one S/G segment with such lengths...
I am quite sure there cannot be - however the WARN clearly shows that we
got passed one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists