linux-kernel - Re: [PATCH] net: ppp_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090111114553.GA19261@localhost>
Date:	Sun, 11 Jan 2009 14:45:53 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Paul Mackerras <paulus@...ba.org>
Cc:	David Miller <davem@...emloft.net>, akpm@...ux-foundation.org,
	jchapman@...alix.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: ppp_generic - fix broken userspace

[Paul Mackerras - Sun, Jan 11, 2009 at 09:29:49PM +1100]
| David Miller writes:
| 
| > PPP was converted to use IDR instead of PPP's duplicate
| > implementation.
| > 
| > A bug was introduced in that conversion, and that bug is being fixed
| > here.
| > 
| > What is not to like? :-)
| 
| Ah OK, that sounds all right.  I was reacting to the "broken
| userspace" in the patch description which at first glance seemed to be
| saying that userspace (i.e. pppd :) is doing something which has
| recently been declared to be wrong and therefore it is "broken".
| 
| I think "fix broken userspace" as a patch headline is quite
| ambiguous.  Something like "Fix bug in conversion to use IDR" would be
| more informative.
| 
| Paul.
| 

David, if you pick this patch could you rename
the subject then as Paul proposed? Or I should
resend the patch with new title?

To Paul: my bad, sorry. I thought like -- I broke
user-space pppd so it's broken now and lets fix
it -- here is "fix broken userspace" grown from :)

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/