linux-kernel - Re: [PATCH] net: ppp_generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090112.221224.170349434.davem@davemloft.net>
Date:	Mon, 12 Jan 2009 22:12:24 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	gorcunov@...il.com
Cc:	paulus@...ba.org, akpm@...ux-foundation.org, jchapman@...alix.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: ppp_generic - fix broken userspace

From: Cyrill Gorcunov <gorcunov@...il.com>
Date: Sun, 11 Jan 2009 14:45:53 +0300

> David, if you pick this patch could you rename
> the subject then as Paul proposed? Or I should
> resend the patch with new title?

Done, here is the commit message I used:

    net: ppp_generic - fix regressions caused by IDR conversion
    
    The commits:
    
    	7a95d267fb62cd6b80ef73be0592bbbe1dbd5df7
    	("net: ppp_generic - use idr technique instead of cardmaps")
    
    	ab5024ab23b78c86a0a1425defcdde48710fe449
    	("net: ppp_generic - use DEFINE_IDR for static initialization")
    
    introduced usage of IDR functionality but broke userspace side.
    
    Before this commits it was possible to allocate new ppp interface with
    specified number. Now it fails with EINVAL.  Fix it by trying to
    allocate interface with specified unit number and return EEXIST if
    fail which allow pppd to ask us to allocate new unit number.
    
    And fix messages on memory allocation fails - add details that it's
    PPP module who is complaining.
    
    Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
    Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/