[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090113185239.GC14470@localhost>
Date: Tue, 13 Jan 2009 21:52:39 +0300
From: Cyrill Gorcunov <gorcunov@...il.com>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: Harvey Harrison <harvey.harrison@...il.com>,
Ingo Molnar <mingo@...e.hu>,
Thomas Gleixner <tglx@...utronix.de>,
Sam Ravnborg <sam@...nborg.org>,
LKML <linux-kernel@...r.kernel.org>,
Jaswinder Singh Rajput <jaswinderlinux@...il.com>
Subject: Re: [PATCH -tip] x86: headers - fix export private data to
userspace
[H. Peter Anvin - Tue, Jan 13, 2009 at 10:49:24AM -0800]
| Harvey Harrison wrote:
| > On Tue, 2009-01-13 at 21:34 +0300, Cyrill Gorcunov wrote:
| >> Impact: cleanup
| >
| >> 4) setup.h - COMMAND_LINE_SIZE saved for userspace, bootloaders
| >> could use it.
| >
| > Doesn't this need to be (at least) _COMMAND_LINE_SIZE to avoid
| > polluting the namespace, not sure it can be changed though as the
| > horse is already out of the barn.
|
| No, this is not one of those cases, but it's worth explaining why.
|
| You can introduce symbols into the general namespace if *and only if*
| they are in a header file that is invoked directly by the user. In
| other words, such a header file is unusable by libc, but setup.h doesn't
| contain anything needed by libc in the first place.
|
| -hpa
|
| --
| H. Peter Anvin, Intel Open Source Technology Center
| I work for Intel. I don't speak on their behalf.
|
So we could just fence it by __KERNEL__?
- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists