linux-kernel - Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI instructions for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231814947.5937.124.camel@yhuang-dev.sh.intel.com>
Date:	Tue, 13 Jan 2009 10:49:07 +0800
From:	Huang Ying <ying.huang@...el.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Sebastian Siewior <linux-crypto@...breakpoint.cc>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI
	instructions for x86_64 platform

On Tue, 2009-01-13 at 10:39 +0800, Herbert Xu wrote:
> On Tue, Jan 13, 2009 at 10:34:13AM +0800, Huang Ying wrote:
> > 
> > static void ablk_complete(struct crypto_async_request *req, int err)
> > {
> >         struct ablkcipher_request *ablk_req = ablkcipher_request_cast(req);
> >         struct async_aes_req_ctx *req_ctx =
> >                 ablk_aes_req_ctx(ablk_req, crypto_ablkcipher_reqtfm(ablk_req));
> 
> This is not guaranteed to work.  Your completion caller may be
> called with a request pointer other than the one that you passed
> to it.  The only thing we guarantee is that req->data has the
> value that you set at the beginning.

I can set req->data in xx_encrypt() to my original request to solve this
issue. Except that, does this solution work?

Best Regards,
Huang Ying


Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)