linux-kernel - Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI instructions for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2009 13:39:38 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Huang Ying <ying.huang@...el.com>
Cc:	Sebastian Siewior <linux-crypto@...breakpoint.cc>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: Re: [RFC PATCH crypto 4/4] AES-NI: Add support to Intel AES-NI
	instructions for x86_64 platform

On Tue, Jan 13, 2009 at 10:34:13AM +0800, Huang Ying wrote:
> 
> static void ablk_complete(struct crypto_async_request *req, int err)
> {
>         struct ablkcipher_request *ablk_req = ablkcipher_request_cast(req);
>         struct async_aes_req_ctx *req_ctx =
>                 ablk_aes_req_ctx(ablk_req, crypto_ablkcipher_reqtfm(ablk_req));

This is not guaranteed to work.  Your completion caller may be
called with a request pointer other than the one that you passed
to it.  The only thing we guarantee is that req->data has the
value that you set at the beginning.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/