linux-kernel - Re: Use cryptd(%s) as cryptd-ed algorithm name instead of %s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231916511.5937.151.camel@yhuang-dev.sh.intel.com>
Date:	Wed, 14 Jan 2009 15:01:51 +0800
From:	Huang Ying <ying.huang@...el.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: Re: Use cryptd(%s) as cryptd-ed algorithm name instead of %s

On Wed, 2009-01-14 at 14:53 +0800, Herbert Xu wrote:
> On Wed, Jan 14, 2009 at 02:44:08PM +0800, Huang Ying wrote:
> > Because:
> > 
> > 1. if use %s, you can only request cryptd(<driver name>), not
> >    cryptd(<alg name>), because generated new algorithm instance has
> >    algorithm name: <alg name> and driver name cryptd(<driver name>).
> 
> This is intentional.  For the purposes we talked about we should
> be requesting cryptd(<driver name>), as otherwise you may end up
> with someone else's AES algorithm as the base.

Current cryptd works well for AES-NI implementation. But how about
somebody want cryptd(cbc(aes)), and don't care about the driver.

> > 2. Generated cryptd-ed algorithm will have the same algorithm name and
> >    higher priority, but some user may not want to use cryptd-ed
> >    version.
> 
> The priority shouldn't be an issue in our case since the AES-NI
> algorithm should register itself as an ablkcipher with an even
> higher priority.

Yes, not an issue for AES-NI case until now. But, for example there is
no aes-ni, if someone request cryptd(cbc(aes-asm)), other user will get
cryptd(cbc(aes-asm)) instead of cbc(aes-asm) when request cbc(aes), is
this a good behavior?

Best Regards,
Huang Ying


Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)