linux-kernel - Re: [3/7] dst: export node.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090114151132.GB6419@ioremap.net>
Date:	Wed, 14 Jan 2009 18:11:32 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org,
	dst@...emap.net
Subject: Re: [3/7] dst: export node.

On Wed, Jan 14, 2009 at 03:52:05PM +0100, Jens Axboe (jens.axboe@...cle.com) wrote:
> On Wed, Jan 14 2009, Evgeniy Polyakov wrote:
> > +	bio = bio_alloc_bioset(GFP_KERNEL,
> > +			PAGE_ALIGN(cmd->size) >> PAGE_SHIFT,
> > +			dst_bio_set);
> > +	if (!bio)
> > +		goto err_out_exit;
> > +	bio->bi_private = NULL;
> > +
> > +	priv = mempool_alloc(st->node->trans_pool, GFP_KERNEL);
> > +	if (!priv)
> > +		goto err_out_free;
> 
> Did you know that you can now set the appropriate extra size for your
> private bio set, thus getting rid of this extra 'priv' allocation and
> free for each bio?
> 
> See bioset_create().

Yes, that's a good idea, I will update the patch with that changes in
mind. Thanks Jens.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/