linux-kernel - Re: [PATCH v3 1/2] sched: de CPP-ify the scheduler code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <496E04BB.5010206@novell.com>
Date:	Wed, 14 Jan 2009 10:28:59 -0500
From:	Gregory Haskins <ghaskins@...ell.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	mingo@...e.hu, rostedt@...e.goodmis.org, peterz@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] sched: de CPP-ify the scheduler code

Steven Rostedt wrote:
>
> On Wed, 14 Jan 2009, Gregory Haskins wrote:
>
>   
>>  
>> -#define enqueue_pushable_task(rq, p) do { } while (0)
>> -#define dequeue_pushable_task(rq, p) do { } while (0)
>> +static inline
>> +void enqueue_pushable_task(struct rq *rq, struct task_struct *p) {}
>> +static inline
>> +void dequeue_pushable_task(struct rq *rq, struct task_struct *p) {}
>>     
>
> Wouldn't the above look better as:
>
> static inline void
> enqueue_pushable_task(struct rq *rq, struct task_struct *p)
> {
> }
> static inline void
> dequeue_pushable_task(struct rq *rq, struct task_struct *p)
> {
> }
>
>   
I personally like to try to keep disabled functions ideally as close to
one line as possible to visually denote that it isn't doing anything
worth looking at.  But I don't feel strongly either way, so whatever
makes you guys happy. :)

Shall I convert the others to this form as well?

-Greg




Download attachment "signature.asc" of type "application/pgp-signature" (258 bytes)