linux-kernel - Re: [PATCH -v9][RFC] mutex: implement adaptive spinning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0901140739110.6528@localhost.localdomain>
Date:	Wed, 14 Jan 2009 07:43:02 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Chris Mason <chris.mason@...cle.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Gregory Haskins <ghaskins@...ell.com>,
	Matthew Wilcox <matthew@....cx>,
	Andi Kleen <andi@...stfloor.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-btrfs <linux-btrfs@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Nick Piggin <npiggin@...e.de>,
	Peter Morreale <pmorreale@...ell.com>,
	Sven Dietrich <SDietrich@...ell.com>,
	Dmitry Adamushko <dmitry.adamushko@...il.com>
Subject: Re: [PATCH -v9][RFC] mutex: implement adaptive spinning



On Wed, 14 Jan 2009, Ingo Molnar wrote:

> 
> * Chris Mason <chris.mason@...cle.com> wrote:
> 
> > v10 is better that not spinning, but its in the 5-10% range.  So, I've 
> > been trying to find ways to close the gap, just to understand exactly 
> > where it is different.
> > 
> > If I take out:
> > 	/*
> > 	 * If there are pending waiters, join them.
> > 	 */
> > 	if (!list_empty(&lock->wait_list))
> > 		break;
> > 
> > 
> > v10 pops dbench 50 up to 1800MB/s.  The other tests soundly beat my 
> > spinning and aren't less fair.  But clearly this isn't a good solution.
> 
> i think since we already decided that it's ok to be somewhat unfair (_all_ 
> batching constructs introduce unfairness, so the question is never 'should 
> we?' but 'by how much?'), we should just take this out and enjoy the speed 

Yeah, let's just do it. It's going to be unfair, but let's see if the 
unfairness is going to actually be noticeable in real life. I suspect it 
isn't, and if it is, we can look at it again and see if there are other 
approaches.

If it makes _that_ much of a difference on dbench, it's worth being unfair 
even if it's just for some dubious benchmark.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/