[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090113.202531.43266519.davem@davemloft.net>
Date: Tue, 13 Jan 2009 20:25:31 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: herbert@...dor.apana.org.au
Cc: zbr@...emap.net, dada1@...mosbay.com, w@....eu, ben@...s.com,
jarkao2@...il.com, mingo@...e.hu, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, jens.axboe@...cle.com
Subject: Re: [PATCH] tcp: splice as many packets as possible at once
From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 14 Jan 2009 14:51:24 +1100
> Unfortunately this won't work, not even for network destinations.
>
> The reason is that this gets called as soon as the destination's
> splice hook returns, for networking that means when sendpage returns.
>
> So by that time we'll still be left with just a page reference
> on a page where the slab memory may already have been freed.
>
> To make this work we need to get the destination's splice hooks
> to acquire this reference.
Yes I realized this after your earlier posting today.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists