[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <1232066983.4923.5.camel@minggr.sh.intel.com>
Date: Fri, 16 Jan 2009 08:49:43 +0800
From: Lin Ming <ming.m.lin@...el.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Mike Galbraith <efault@....de>,
"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>,
"dev@...sonking.com" <dev@...sonking.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: Performance regression of specjbb2005/aim7 with 2.6.29-rc1
On Fri, 2009-01-16 at 00:17 +0800, Peter Zijlstra wrote:
> On Thu, 2009-01-15 at 10:30 +0800, Lin Ming wrote:
>
> > Below patch fixes aim7 regression and specjbb2005 regression becomes
> > less than 1.5% on 8-core stokley.
>
> Ingo, please apply the below.
>
> Ming, would you also provide a S-o-b line?
Yes,
Signed-off-by: Lin Ming <ming.m.lin@...el.com>
Lin Ming
>
> ---
> Subject: sched_slice fixlet
> From: Lin Ming <ming.m.lin@...el.com>
> Date: Thu Jan 15 17:10:02 CET 2009
>
> Mike's change: 0a582440f -- sched: fix sched_slice())
> Broke group scheduling by forgetting to reload cfs_rq on each loop.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> ---
> kernel/sched_fair.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/kernel/sched_fair.c
> ===================================================================
> --- linux-2.6.orig/kernel/sched_fair.c
> +++ linux-2.6/kernel/sched_fair.c
> @@ -429,7 +429,10 @@ static u64 sched_slice(struct cfs_rq *cf
> u64 slice = __sched_period(cfs_rq->nr_running + !se->on_rq);
>
> for_each_sched_entity(se) {
> - struct load_weight *load = &cfs_rq->load;
> + struct load_weight *load;
> +
> + cfs_rq = cfs_rq_of(se);
> + load = &cfs_rq->load;
>
> if (unlikely(!se->on_rq)) {
> struct load_weight lw = cfs_rq->load;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists