linux-kernel - Re: [PATCH] x86: avoid early crash in disable_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090116130936.GL5421@elte.hu>
Date:	Fri, 16 Jan 2009 14:09:36 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jan Beulich <jbeulich@...ell.com>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: [PATCH] x86: avoid early crash in disable_local_APIC()


* Jan Beulich <jbeulich@...ell.com> wrote:

> >>> Ingo Molnar <mingo@...e.hu> 15.01.09 23:47 >>>
> >
> >* Ingo Molnar <mingo@...e.hu> wrote:
> >
> >> hm, this gives a build failure on latest -tip:
> >> 
> >> arch/x86/kernel/apic.c: In function 'setup_local_APIC':
> >> arch/x86/kernel/apic.c:1135: error: implicit declaration of function 'disable_ioapic_setup'
> 
> Is this with a config that has X86_IO_APIC off (i.e. one the practical 
> use of which I never understood, and hence easily forget to consider)? 
> Otherwise I can't see how that could happen.

yeah. Such build failures are reminders to define such functions in a 
.config-invariant way: i.e. an extern prototype plus an inline NOP-wrapper 
for the !IO_APIC case.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/