linux-kernel - Re: [PATCH v1 1/8] Deferred batching of dput()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090117101501.GA2682@ioremap.net>
Date:	Sat, 17 Jan 2009 13:15:01 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Mike Waychison <mikew@...gle.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v1 1/8] Deferred batching of dput()

Hi Mike.

On Fri, Jan 16, 2009 at 06:29:42PM -0800, Mike Waychison (mikew@...gle.com) wrote:
> +static void postpone_dput(struct dentry *dentry)
> +{
> +	struct postponed_dentries *ppd, *new_ppd;
> +
> +again:
> +	ppd = get_cpu_var(postponed_dentries);
> +	if (!pending_dput_full(ppd)) {
> +		add_pending_dput(ppd, dentry);
> +		put_cpu_var(postponed_dentries);
> +		return;
> +	}
> +
> +	/* need to flush out existing pending dentries. */
> +	put_cpu_var(postponed_dentries);
> +	/* Allocate more space.. */
> +	new_ppd = new_postponed_dentries();
> +	if (!new_ppd) {
> +		/* Take the slow path, memory is low */
> +		struct postponed_dentries_onstack ppd_onstack;
> +		struct postponed_dentries *ppd;
> +
> +		ppd = init_ppd_onstack(&ppd_onstack);
> +		add_pending_dput(ppd, dentry);
> +		process_postponed_dentries(ppd);
> +		return;
> +	}

Why don't you want just to put the dentry in the lowmem condition?

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/