lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090117101809.GB2682@ioremap.net>
Date:	Sat, 17 Jan 2009 13:18:09 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Mike Waychison <mikew@...gle.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v1 3/8] Deferred batching of iput()

On Fri, Jan 16, 2009 at 06:29:52PM -0800, Mike Waychison (mikew@...gle.com) wrote:
> +static void postpone_iput(struct inode *inode)
> +{
> +	struct postponed_inodes *ppi, *new_ppi;
> +
> +again:
> +	ppi = get_cpu_var(postponed_inodes);
> +	if (!pending_iput_full(ppi)) {
> +		add_pending_iput(ppi, inode);
> +		put_cpu_var(postponed_inodes);
> +		return;
> +	}
> +
> +	/* Need to flush out existing pending inodes */
> +	put_cpu_var(postponed_inodes);
> +	/* Allocate more space.. */
> +	new_ppi = new_postponed_inodes();
> +	if (!new_ppi) {
> +		struct postponed_inodes_onstack ppi_onstack;
> +
> +		ppi = init_ppi_onstack(&ppi_onstack);
> +		add_pending_iput(ppi, inode);
> +		process_postponed_inodes(ppi);
> +		return;
> +	}

The same here: what just not to call a real_iput() without on-stack
allocation and the line?

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ