linux-kernel - Re: [GIT PULL -tip v3] fix 39 'make headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Jan 2009 18:20:46 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sam Ravnborg <sam@...nborg.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings

On Mon, 2009-01-19 at 07:40 +0530, Jaswinder Singh Rajput wrote:
> On Sun, 2009-01-18 at 19:50 +0100, Ingo Molnar wrote:
> >  
> > why does such a change introduce new code? It is duplicating existing code 
> > instead of cleaning it all up.
> > 
> 
> That's why I was requesting you to check asm/swab.h because I was in
> doubt whether we need these functions in userspace or not.
> 
> If we do not need these functions in userspace then I will clean these
> up.
> 

As part of doing the swab.h splitout it was very tempting to just stop
exporting _all_ of the asm/swab.h files now that there is a linux/swab.h.
But I ended up leaving things as they were on arches that did expose
their arch specific versions to userspace.

Just a thought.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/