linux-kernel - Re: [GIT PULL -tip v3] fix 39 'make headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090119052727.GA6422@uranus.ravnborg.org>
Date:	Mon, 19 Jan 2009 06:27:28 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL -tip v3] fix 39 'make headers_check' warnings

On Mon, Jan 19, 2009 at 07:46:05AM +0530, Jaswinder Singh Rajput wrote:
> On Sun, 2009-01-18 at 20:08 +0100, Sam Ravnborg wrote:
> > > 
> > > diff --git a/arch/x86/include/asm/swab.h b/arch/x86/include/asm/swab.h
> > > index 306d417..613be68 100644
> > > --- a/arch/x86/include/asm/swab.h
> > > +++ b/arch/x86/include/asm/swab.h
> > > @@ -1,12 +1,15 @@
> > >  #ifndef _ASM_X86_SWAB_H
> > >  #define _ASM_X86_SWAB_H
> > >  
> > > -#include <asm/types.h>
> > > +#include <linux/types.h>
> > > +#ifdef __KERNEL__
> > >  #include <linux/compiler.h>
> > > +#endif /* __KERNEL__ */
> > 
> > compiler.h includes should be nuked by make headers_instll automatically.
> > 
> 
> But the problem is compiler.h provide extra line space in userspace
> header files because of nuking them.
> 
> So I moved compiler.h in __KERNEL__ as extra cleanup, it is not harmful
> but looks much nicer in userspace header files

We should fix scripts/headers_install.pl to drop the newline too.
This is much better than adding of ifdef __KERNEL__ around
the include of compiler.h.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/