linux-kernel - Re: [RFC] Regulator: Push lock out of _notifier_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1232482147.16911.295.camel@vega.slimlogic.co.uk>
Date:	Tue, 20 Jan 2009 20:09:07 +0000
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	Jonathan Cameron <Jonathan.Cameron@...il.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] Regulator: Push lock out of _notifier_call_chain + add
 voltage change event.

On Mon, 2009-01-19 at 18:20 +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <jic23@....ac.uk>
> Regulator: Push lock out of _notifier_call_chain and into caller functions
> (side effect of fixing deadlock in regulator_force_disable)
> + Add a voltage changed event.
> Signed-off-by: Jonathan Cameron <jic23@....ac.uk>
> 
> ---
> Follow up to Mark Brown's suggestion of moving the regulator lock out
> of the notifier code.  This avoids cases where it was previously necessary
> to unlock the regulator before notification occured.
> 
> Any scenarios where this will cause trouble?
> 
> I'll do a documentation patch when we've pinned down how to do this.
> + can break the patch into one for pushing the lock out and one for
> adding the event.
> 
>  drivers/regulator/core.c             |   15 ++++++++++-----
>  drivers/regulator/wm8350-regulator.c |    2 ++
>  drivers/regulator/wm8400-regulator.c |    2 +-
>  include/linux/regulator/consumer.h   |    2 ++
>  4 files changed, 15 insertions(+), 6 deletions(-)
> 

Applied and fixed trailing white space.

Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/