linux-kernel - Re: [PATCH 5/6] x86: Merge hardirq.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090121101307.GD18728@elte.hu>
Date:	Wed, 21 Jan 2009 11:13:07 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Tejun Heo <tj@...nel.org>
Cc:	Brian Gerst <brgerst@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] x86: Merge hardirq.h

* Tejun Heo <tj@...nel.org> wrote:

> Brian Gerst wrote:
> > Remove unused idle_timestamp field from 32-bit.
> 
> Dropped.  X86_32 doesn't build.  X86_64 UP doesn't build.  Please at 
> least do compile testing on all four combinations before sending the 
> patches.

While this patch was indeed broken, generally for -tip patches we are very 
permissive and do not require testing 4 .config variants: compile testing 
on the bit width x86 variant that is being modified is enough. If both 
variant are modified (as in this case) then compiling the 32-bit and 
64-bit defconfig is enough.

If some build failure slips through it will be handled by automated 
testing facilities (such as -tip's testing) - it really does not scale if 
we expect developers to build kernels they dont use (and dont care about 
nearly as much as about their primary config).

This lowers the bar of entry to developers who submit their patches from 
low-powered hardware and simply dont have the means to do wide build 
testing. The many .config variations are not really the developer's fault 
but our collective fault. Developers should spend their time thinking 
about patches, not waiting for the nth kernel build to finish.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/