linux-kernel - Re: [PATCH 5/6] x86: Merge hardirq.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090121101400.GE18728@elte.hu>
Date:	Wed, 21 Jan 2009 11:14:00 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Tejun Heo <htejun@...il.com>
Cc:	Brian Gerst <brgerst@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] x86: Merge hardirq.h


* Tejun Heo <htejun@...il.com> wrote:

> Tejun Heo wrote:
> > Brian Gerst wrote:
> >> Remove unused idle_timestamp field from 32-bit.
> > 
> > Dropped.  X86_32 doesn't build.  X86_64 UP doesn't build.  Please at
> > least do compile testing on all four combinations before sending the
> > patches.
> 
> One more thing, can you please split the patch into two such that the 
> merging and renaming happen as separate steps so that git can tell that 
> a file has been renamed instead of oh two of those disappeared and this 
> one popped up?  It's a bit tedious but makes log tracking much easier.

yes, we do that for all unification patches - the 'large patch' must 
always be a simple "git mv", with nothing modified inbetween. That way 
it's reviewable and debuggable as well.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/