linux-kernel - [PATCH] HVC: do not request the irq twice.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1232646968-32671-1-git-send-email-Ian.Campbell@citrix.com>
Date:	Thu, 22 Jan 2009 17:56:08 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	linux-kernel@...r.kernel.org
Cc:	Ian Campbell <Ian.Campbell@...rix.com>,
	Ian Campbell <ian.campbell@...rix.com>,
	Milton Miller <miltonm@....com>,
	Christian Borntraeger <borntraeger@...ibm.com>,
	Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: [PATCH] HVC: do not request the irq twice.

Otherwise:
  root@...ga:~# tty
  /dev/hvc0
  root@...ga:~# reboot


  Broadcast message from root@...ga (hvc0) (Thu Jan 22 17:51:20 2009):

  The system is going down for reboot NOW!
  INIT: Switching to runlevel: 6
  INIT: Sending processes the TERM signal
  hvc_open: request_irq failed with rc -16.

Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
Cc: Milton Miller <miltonm@....com>
Cc: Christian Borntraeger <borntraeger@...ibm.com>
Cc: Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Rusty Russell <rusty@...tcorp.com.au>
---
 drivers/char/hvc_irq.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/char/hvc_irq.c b/drivers/char/hvc_irq.c
index 2623e17..8152a13 100644
--- a/drivers/char/hvc_irq.c
+++ b/drivers/char/hvc_irq.c
@@ -28,6 +28,10 @@ int notifier_add_irq(struct hvc_struct *hp, int irq)
 		hp->irq_requested = 0;
 		return 0;
 	}
+
+	if (hp->irq_requested)
+		return 0;
+
 	rc = request_irq(irq, hvc_handle_interrupt, IRQF_DISABLED,
 			   "hvc_console", hp);
 	if (!rc)
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/