linux-kernel - Re: [PATCH] SLUB: revert direct page allocator pass through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1232726833.6094.110.camel@penberg-laptop>
Date:	Fri, 23 Jan 2009 18:07:13 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Nick Piggin <nickpiggin@...oo.com.au>
Cc:	Christoph Lameter <cl@...ux-foundation.org>,
	yanmin_zhang@...ux.intel.com, Andi Kleen <andi@...stfloor.org>,
	Matthew Wilcox <matthew@....cx>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] SLUB: revert direct page allocator pass through

On Sat, 2009-01-24 at 02:37 +1100, Nick Piggin wrote:
> > > However, I don't know if netperf udp 4K over loopback is totally
> > > realistic. Maybe real network drivers have different allocation patterns.
> > > If I were you I wouldn't be too hasty to make big changes based on that
> > > alone, if it could introduce regression in somewhere more important.

On Saturday 24 January 2009 02:44:28 Pekka Enberg wrote:
> > Yup, I'm putting it in linux-next to see if anything pops up. It's of
> > course possible that it will introduce regression somewhere but seeing
> > the hit SLUB is taking from the page allocator, I'm bound to think that
> > performance increase claims of commit
> > aadb4bc4a1f9108c1d0fbd121827c936c2ed4217 ("SLUB: direct pass through of
> > page size or higher kmalloc requests") don't hold anymore.

On Sat, 2009-01-24 at 02:54 +1100, Nick Piggin wrote:
> Well what workload were they relating to? That could easily be retested.

No idea. I'm not sure I even reviewed that patch as it went in.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/