[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1232726658.3504.22.camel@localhost.localdomain>
Date: Fri, 23 Jan 2009 21:34:18 +0530
From: Jaswinder Singh Rajput <jaswinder@...nel.org>
To: "H. Peter Anvin" <hpa@...nel.org>
Cc: Sam Ravnborg <sam@...nborg.org>,
David Woodhouse <dwmw2@...radead.org>,
Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
urs.thuermann@...kswagen.de, oliver.hartkopp@...kswagen.de,
linux-media@...r.kernel.org, netfilter-devel@...r.kernel.org,
netfilter@...r.kernel.org, bfields@...ldses.org, neilb@...e.de,
linux-nfs@...r.kernel.org, linux-raid@...r.kernel.org,
dbrownell@...rs.sourceforge.net, netdev@...r.kernel.org,
greg@...ah.com, linux-usb@...r.kernel.org,
linux-mtd@...ts.infradead.org, tiwai@...e.de,
mchehab@...radead.org, LKML <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
On Fri, 2009-01-23 at 21:29 +0530, Jaswinder Singh Rajput wrote:
> On Wed, 2009-01-21 at 06:08 +0530, Jaswinder Singh Rajput wrote:
> > On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote:
> > > Sam Ravnborg wrote:
> > > >>>
> > > >> That patch looks wrong, and unnecessary. It was fine before.
> > > > Nope - include/linux/dvb/audio.h failed to include linux/types.h
> > > > despite the fact that is uses __u32 etc.
> > > >
> > > > But why the _kernel_ should include a userspace header is
> > > > much more questionable.
> > > >
> > >
> > > <stdint.h> is one of a handful of headers provided by gcc itself.
> > >
> >
> > Should I reintroduce my patch to solve this warning of 'make headers_check':
> > usr/include/linux/dvb/audio.h:133: found __[us]{8,16,32,64} type without #include <linux/types.h>
> >
> > diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h
> > index 89412e1..758a48c 100644
> > --- a/include/linux/dvb/audio.h
> > +++ b/include/linux/dvb/audio.h
> > @@ -24,9 +24,8 @@
> > #ifndef _DVBAUDIO_H_
> > #define _DVBAUDIO_H_
> >
> > -#ifdef __KERNEL__
> > #include <linux/types.h>
> > -#else
> > +#ifndef __KERNEL__
> > #include <stdint.h>
> > #endif
> >
>
> It seems one have objection for this. So I will again insert this in my
> new patchset.
>
oops, s/seems one/seems no one ;-)
--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists