linux-kernel - Re: [GIT PULL -tip] fix 33 make headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.0901231710350.15413@fbirervta.pbzchgretzou.qr>
Date:	Fri, 23 Jan 2009 17:11:13 +0100 (CET)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
cc:	"H. Peter Anvin" <hpa@...nel.org>, Sam Ravnborg <sam@...nborg.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Ingo Molnar <mingo@...e.hu>, x86 maintainers <x86@...nel.org>,
	urs.thuermann@...kswagen.de, oliver.hartkopp@...kswagen.de,
	linux-media@...r.kernel.org, netfilter-devel@...r.kernel.org,
	netfilter@...r.kernel.org, bfields@...ldses.org, neilb@...e.de,
	linux-nfs@...r.kernel.org, linux-raid@...r.kernel.org,
	dbrownell@...rs.sourceforge.net, netdev@...r.kernel.org,
	greg@...ah.com, linux-usb@...r.kernel.org,
	linux-mtd@...ts.infradead.org, tiwai@...e.de,
	mchehab@...radead.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings


On Friday 2009-01-23 17:04, Jaswinder Singh Rajput wrote:
>> > diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h
>> > index 89412e1..758a48c 100644
>> > --- a/include/linux/dvb/audio.h
>> > +++ b/include/linux/dvb/audio.h
>> > @@ -24,9 +24,8 @@
>> >  #ifndef _DVBAUDIO_H_
>> >  #define _DVBAUDIO_H_
>> >  
>> > -#ifdef __KERNEL__
>> >  #include <linux/types.h>
>> > -#else
>> > +#ifndef __KERNEL__
>> >  #include <stdint.h>
>> >  #endif
>> > 
>> 
>> It seems one have objection for this. So I will again insert this in my
>> new patchset.
>> 
>
>oops, s/seems one/seems no one ;-)

I had an objection as previously stated -- namely that
<stdint.h> should be included to remain friendly to C++0x
programs which should use <cstdint> instead. Forcing
stdint.h is therefore not nice.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/