linux-kernel - Re: checkpatch vs. checkpatch --file (was: Re: [Orinoco-devel] [PATCH] orinoco: checkpatch cleanup)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 Jan 2009 19:06:48 +0300
From:	Andrey Borzenkov <arvidjaar@...l.ru>
To:	Andy Whitcroft <apw@...onical.com>
Cc:	Pavel Roskin <proski@....org>, linux-kernel@...r.kernel.org
Subject: Re: checkpatch vs. checkpatch --file (was: Re: [Orinoco-devel] [PATCH] orinoco: checkpatch cleanup)

On 26 января 2009 11:38:30 Andy Whitcroft wrote:
> On Mon, Jan 26, 2009 at 07:13:36AM +0300, Andrey Borzenkov wrote:
> > On 26 января 2009 06:46:02 Pavel Roskin wrote:
> > > Please run the patch itself through checkpatch.  It finds two
> > > errors:
> > >
> > > ERROR: trailing statements should be on next line
> > > #163: FILE: drivers/net/wireless/orinoco/hermes.c:65:
> > > +                       printk(stuff); } while (0)
> > > +                       printk(stuff); } while (0)
> >
> > I ran "checkpatch --file hermes.c" after editing it and it found
> > zero errors.
> >
> > Cc checkpatch maintainer.
>
> Hmmm.  Could I have the patch and the file either before or after
> application please.
>

Sure. Here you have file after editing and patch between original and 
file you get. File passes all checks, patch generates error:

{pts/2}% ~/src/linux-git/scripts/checkpatch.pl --file hermes.c
total: 0 errors, 0 warnings, 554 lines checked

hermes.c has no obvious style problems and is ready for submission.
{pts/2}% ~/src/linux-git/scripts/checkpatch.pl or/02-orinoco-cleanup-
hermes.c
ERROR: trailing statements should be on next line
#42: FILE: drivers/net/wireless/orinoco/hermes.c:65:
+                       printk(stuff); } while (0)
+                       printk(stuff); } while (0)
total: 1 errors, 0 warnings, 288 lines checked

or/02-orinoco-cleanup-hermes.c has style problems, please review.  If 
any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.


View attachment "hermes.c" of type "text/x-csrc" (13987 bytes)

View attachment "02-orinoco-cleanup-hermes.c" of type "text/x-csrc" (10270 bytes)

Download attachment "signature.asc " of type "application/pgp-signature" (198 bytes)