linux-kernel - Re: checkpatch vs. checkpatch --file (was: Re: [Orinoco-devel] [PATCH] orinoco: checkpatch cleanup)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090126083830.GA17399@shadowen.org>
Date:	Mon, 26 Jan 2009 08:38:30 +0000
From:	Andy Whitcroft <apw@...onical.com>
To:	Andrey Borzenkov <arvidjaar@...l.ru>
Cc:	Pavel Roskin <proski@....org>, linux-kernel@...r.kernel.org
Subject: Re: checkpatch vs. checkpatch --file (was: Re: [Orinoco-devel]
	[PATCH] orinoco: checkpatch cleanup)

On Mon, Jan 26, 2009 at 07:13:36AM +0300, Andrey Borzenkov wrote:
> On 26 января 2009 06:46:02 Pavel Roskin wrote:
> >
> > Please run the patch itself through checkpatch.  It finds two errors:
> >
> > ERROR: trailing statements should be on next line
> > #163: FILE: drivers/net/wireless/orinoco/hermes.c:65:
> > +                       printk(stuff); } while (0)
> > +                       printk(stuff); } while (0)
> 
> I ran "checkpatch --file hermes.c" after editing it and it found zero 
> errors.
> 
> Cc checkpatch maintainer.

Hmmm.  Could I have the patch and the file either before or after
application please.

Very strange.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/