linux-kernel - Re: [PATCH] Fix longstanding "error: storage size of '__mod_dmi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090127155719.2b88da3f.akpm@linux-foundation.org>
Date:	Tue, 27 Jan 2009 15:57:19 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	dwmw2@...radead.org
Subject: Re: [PATCH] Fix longstanding "error: storage size of
 '__mod_dmi_device_table' isn't known"

On Thu, 22 Jan 2009 01:58:36 +0300
Alexey Dobriyan <adobriyan@...il.com> wrote:

> gcc 3.4.6 doesn't like MODULE_DEVICE_TABLE(dmi, x) expansion enough to error out.
> Shut it up in a most simple way.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
> 
>  include/linux/mod_devicetable.h |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -443,6 +443,13 @@ struct dmi_system_id {
>  	struct dmi_strmatch matches[4];
>  	void *driver_data;
>  };
> +/*
> + * struct dmi_device_id appears during expansion of
> + * "MODULE_DEVICE_TABLE(dmi, x)". Compiler doesn't look inside it
> + * but this is enough for gcc 3.4.6 to error out:
> + *	error: storage size of '__mod_dmi_device_table' isn't known
> + */
> +#define dmi_device_id dmi_system_id
>  #endif
>  
>  #define DMI_MATCH(a, b)	{ a, b }

I don't get it.

If code has

MODULE_DEVICE_TABLE(dmi, x);

and correctly includes mod_devicetable.h then that code will be
expanded and compiled happily by all compiler versions?  Or not?


Under what circumstances does it fail?  Presumably if some header files
weren't included?  If so, why is that specific to a gcc version?


Or something else.  I have no idea.  Sigh.  New changelog, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/