[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090129063908.GE32243@linux-sh.org>
Date: Thu, 29 Jan 2009 15:39:08 +0900
From: Paul Mundt <lethal@...ux-sh.org>
To: Matt Fleming <matt@...sole-pimps.org>
Cc: linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] sh: Relax inline assembly constraints
On Tue, Jan 20, 2009 at 09:14:37PM +0000, Matt Fleming wrote:
> When dereferencing the memory address contained in a register and
> modifying the value at that memory address, the register should not be
> listed in the inline asm outputs. The value at the memory address is an
> output (which is taken care of with the "memory" clobber), not the register.
>
> Signed-off-by: Matt Fleming <matt@...sole-pimps.org>
On Tue, Jan 20, 2009 at 09:14:38PM +0000, Matt Fleming wrote:
> Now that atomic_t is a generic opaque type for all architectures, it is
> unwise to use intimate knowledge of its internals when manipulating it.
>
> Instead of relying on the "counter" member being at offset 0 from the
> beginning of an atomic_t, explicitly reference the member. This guards
> us from any changes to the layout of the beginning of the atomic_t type.
>
> Signed-off-by: Matt Fleming <matt@...sole-pimps.org>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists