linux-kernel - Re: [PATCH] xen: make sysfs files behave as their names suggest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090129064451.GA22245@verge.net.au>
Date:	Thu, 29 Jan 2009 15:44:54 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Stable Kernel <stable@...nel.org>,
	"dan.magenheimer@...cle.com" <dan.magenheimer@...cle.com>
Subject: Re: [PATCH] xen: make sysfs files behave as their names suggest

On Wed, Jan 28, 2009 at 08:31:25PM -0800, Jeremy Fitzhardinge wrote:
> Simon Horman wrote:
>> On Wed, Jan 28, 2009 at 04:50:20PM -0800, Jeremy Fitzhardinge wrote:
>>   
>>> 1: make "target_kb" only accept and produce a memory size in kilobytes.
>>> 2: add a second "target" file which produces output in bytes, and will accept
>>>   memparse input (scaled bytes)
>>>
>>> This fixes the rather irritating problem that writing the same value
>>> read back into target_kb would end up shrinking the domain by a factor
>>> of 1024, with generally bad results.
>>>     
>>
>> Are there any compatibility issues that we should care about
>> related to this change?
>>   
>
> Well, in theory, but not in practice I think.
>
> It changes the behaviour of target_kb from accepting bytes into  
> kilobytes, and it no longer parses a k/m/g suffix.  The old behaviour  
> was a definite bug, given the name of the file, so I consider this to be  
> pure bugfix.  The kernel introducing this interface has only been out  
> for a week or two, so I don't think there's much chance anyone has  
> started relying on the buggy behaviour.

Thanks for the clarification. I have no objections.

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/