linux-kernel - Re: [PATCH] w35und: fix registration with wlan stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1233306980.4161.19.camel@johannes.local>
Date:	Fri, 30 Jan 2009 10:16:20 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Pavel Machek <pavel@...e.cz>,
	Sandro Bonazzola <sandro.bonazzola@...il.com>,
	kernel list <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Bruno Randolf <br1@...fach.org>
Subject: Re: [PATCH] w35und: fix registration with wlan stack

On Fri, 2009-01-30 at 11:13 +0200, Pekka Enberg wrote:


> >  	dev->extra_tx_headroom = 12;	/* FIXME */
> > -	dev->flags = 0;
> > +	dev->flags = IEEE80211_HW_SIGNAL_UNSPEC;
> > +	dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
> 
> The wiphy->interface_modes thing is probably fall-out from commit
> 8dffff216fcac4f79078478085e86d68db64922e ("mac80211: only create default
> STA interface if supported"). I'm cc'ing Johannes.

Yes. That looks reasonable, though it means you'll only support STA, not
ad-hoc.

> >  
> >  	dev->channel_change_time = 1000;
> > +	dev->max_signal = 100;
> 
> And the IEEE80211_HW_SIGNAL_UNSPEC and ->max_signal from commit
> 566bfe5a8bcde13188a356f77666f8115813cf31 ("mac80211: use hardware flags
> for signal/noise units"). Lets cc Bruno.

Seems reasonable, though does it would be good to see if it can do DBM,
which we very very much prefer.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)