linux-kernel - Re: [PATCH] w35und: fix registration with wlan stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090130093846.GC9495@atrey.karlin.mff.cuni.cz>
Date:	Fri, 30 Jan 2009 10:38:46 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Pekka Enberg <penberg@...helsinki.fi>,
	Sandro Bonazzola <sandro.bonazzola@...il.com>,
	kernel list <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>, Bruno Randolf <br1@...fach.org>
Subject: Re: [PATCH] w35und: fix registration with wlan stack

> On Fri, 2009-01-30 at 11:13 +0200, Pekka Enberg wrote:
> 
> 
> > >  	dev->extra_tx_headroom = 12;	/* FIXME */
> > > -	dev->flags = 0;
> > > +	dev->flags = IEEE80211_HW_SIGNAL_UNSPEC;
> > > +	dev->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
> > 
> > The wiphy->interface_modes thing is probably fall-out from commit
> > 8dffff216fcac4f79078478085e86d68db64922e ("mac80211: only create default
> > STA interface if supported"). I'm cc'ing Johannes.
> 
> Yes. That looks reasonable, though it means you'll only support STA, not
> ad-hoc.

Ok. The driver is very basic for now (can only do channel 1), so we
certainly have bigger problems than ad-hoc.

> > >  	dev->channel_change_time = 1000;
> > > +	dev->max_signal = 100;
> > 
> > And the IEEE80211_HW_SIGNAL_UNSPEC and ->max_signal from commit
> > 566bfe5a8bcde13188a356f77666f8115813cf31 ("mac80211: use hardware flags
> > for signal/noise units"). Lets cc Bruno.
> 
> Seems reasonable, though does it would be good to see if it can do DBM,
> which we very very much prefer.

Well, currenlty it reports all zeros...
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/