linux-kernel - Re: [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested ssc instance is not found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090130102654.10e4aafc@hskinnemoen-d830>
Date:	Fri, 30 Jan 2009 10:26:54 +0100
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	dbrownell@...rs.sourceforge.net, kay.sievers@...y.org,
	weiyi.huang@...il.com, Andrew Victor <avictor.za@...il.com>
Subject: Re: [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested ssc
 instance is not found

[CCs added]

Hans-Christian Egtvedt wrote:
> This patch replaces the dev_dbg(...) with a pr_err since the ssc pointer
> is not valid when the id is not found in the list.
> 
> Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>

Acked-by: Haavard Skinnemoen <haavard.skinnemoen@...el.com>

...or should I just apply it to the avr32 tree?

Haavard

> ---
>  drivers/misc/atmel-ssc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 6b35874..6cff1bb 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -35,7 +35,7 @@ struct ssc_device *ssc_request(unsigned int ssc_num)
>  
>  	if (!ssc_valid) {
>  		spin_unlock(&user_lock);
> -		dev_dbg(&ssc->pdev->dev, "could not find requested device\n");
> +		pr_err("ssc: ssc%d platform device is missing\n", ssc_num);
>  		return ERR_PTR(-ENODEV);
>  	}
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/