[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090130003818.GB5862@nowhere>
Date: Fri, 30 Jan 2009 01:38:19 +0100
From: Frederic Weisbecker <fweisbec@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: rostedt@...dmis.org, mingo@...e.hu, linux-kernel@...r.kernel.org,
acme@...stprotocols.net
Subject: Re: [PATCH] tracing/ftrace: add an option to not print the context
info for events
On Thu, Jan 29, 2009 at 04:19:56PM -0800, Andrew Morton wrote:
> On Tue, 20 Jan 2009 16:52:36 -0800 (PST)
> Frederic Weisbecker <fweisbec@...il.com> wrote:
>
> > + usec_rem = do_div(t, 1000000ULL);
>
> The second argument to do_div() is in fact a u32. It's quite hard to
> track this down due to use of macros and lack of comemnts.
>
> Doing
>
> usec_rem = do_div(t, USEC_PER_SEC);
>
> would suit here.
Thanks, I've fixed it for the next version of this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists