linux-kernel - Re: [PATCH -next/mmotm/resend] kmemtrace: fix printk formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 30 Jan 2009 16:12:51 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next/mmotm/resend] kmemtrace: fix printk formats


* Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro> wrote:

> On Thu, Jan 29, 2009 at 01:49:45PM -0800, Randy Dunlap wrote:
> > Geert Uytterhoeven wrote:
> > > 
> > > %4zu?
> > 
> > Ugh, yes.  Thanks.
> > Here's the updated patch.
> > 
> > -- 
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > Fix kmemtrace printk warnings:
> > 
> > kernel/trace/kmemtrace.c:142: warning: format '%4ld' expects type 'long int', but argument 3 has type 'size_t'
> > kernel/trace/kmemtrace.c:147: warning: format '%4ld' expects type 'long int', but argument 3 has type 'size_t'
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> > cc:      Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
> > ---
> >  kernel/trace/kmemtrace.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > --- linux-next-20090123.orig/kernel/trace/kmemtrace.c
> > +++ linux-next-20090123/kernel/trace/kmemtrace.c
> > @@ -139,12 +139,12 @@ kmemtrace_print_alloc_compress(struct tr
> >  		return TRACE_TYPE_PARTIAL_LINE;
> >  
> >  	/* Requested */
> > -	ret = trace_seq_printf(s, "%4ld   ", entry->bytes_req);
> > +	ret = trace_seq_printf(s, "%4zu   ", entry->bytes_req);
> >  	if (!ret)
> >  		return TRACE_TYPE_PARTIAL_LINE;
> >  
> >  	/* Allocated */
> > -	ret = trace_seq_printf(s, "%4ld   ", entry->bytes_alloc);
> > +	ret = trace_seq_printf(s, "%4zu   ", entry->bytes_alloc);
> >  	if (!ret)
> >  		return TRACE_TYPE_PARTIAL_LINE;
> >
> 
> I didn't notice this either, thanks.
> 
> Acked-by: Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>

Applied to tip/tracing/kmemtrace, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/