linux-kernel - [PATCH][iSCSI-SCST]: Fix list corruption if SCST target registration fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <498344E0.6000304@vlnb.net>
Date:	Fri, 30 Jan 2009 21:20:16 +0300
From:	Vladislav Bolkhovitin <vst@...b.net>
To:	linux-scsi@...r.kernel.org
CC:	linux-kernel@...r.kernel.org, scst-devel@...ts.sourceforge.net
Subject: [PATCH][iSCSI-SCST]: Fix list corruption if SCST target registration
 fails

This patch fixes list corruption if SCST target registration fails.

Signed-off-by: Arne Redlich <agr@...erkom-dd.de>
Signed-off-by: Vladislav Bolkhovitin <vst@...b.net>

 target.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: iscsi-scst/kernel/target.c
===================================================================
--- iscsi-scst/kernel/target.c	(revision 648)
+++ iscsi-scst/kernel/target.c	(working copy)
@@ -116,8 +116,6 @@ static int iscsi_target_create(struct ta
 	mutex_init(&target->target_mutex);
 	INIT_LIST_HEAD(&target->session_list);
 
-	list_add(&target->target_list_entry, &target_list);
-
 	target->scst_tgt = scst_register(&iscsi_template, target->name);
 	if (!target->scst_tgt) {
 		PRINT_ERROR("%s", "scst_register() failed");
@@ -125,6 +123,8 @@ static int iscsi_target_create(struct ta
 		goto out_free;
 	}
 
+	list_add(&target->target_list_entry, &target_list);
+
 	return 0;
 
 out_free:

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/