linux-kernel - Re: [PATCH 3/4] kthreads: rework kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090130134736.ce5910aa.akpm@linux-foundation.org>
Date:	Fri, 30 Jan 2009 13:47:36 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	hch@....de, ebiederm@...ssion.com, mingo@...e.hu, xemul@...nvz.org,
	rusty@...tcorp.com.au, vgusev@...nvz.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] kthreads: rework kthread_stop()

On Fri, 30 Jan 2009 13:33:58 +0100
Oleg Nesterov <oleg@...hat.com> wrote:

>  int kthread_stop(struct task_struct *k)
>  {
> +	struct kthread *kthread;
>  	int ret;
>  
> -	mutex_lock(&kthread_stop_lock);
> -
> -	/* It could exit after stop_info.k set, but before wake_up_process. */
> -	get_task_struct(k);
> -
>  	trace_sched_kthread_stop(k);
> +	get_task_struct(k);
>  
> -	/* Must init completion *before* thread sees kthread_stop_info.k */
> -	init_completion(&kthread_stop_info.done);
> -	smp_wmb();
> +	kthread = to_kthread(k);
> +	barrier(); /* it might have exited */

Why the change from smp_wmb() to plain old barrier()?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/