[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090131.210651.126573837.anemo@mba.ocn.ne.jp>
Date: Sat, 31 Jan 2009 21:06:51 +0900 (JST)
From: Atsushi Nemoto <anemo@....ocn.ne.jp>
To: dan.j.williams@...el.com
Cc: hskinnemoen@...el.com, kernel@...32linux.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atmel-mci: fix initialization of dma slave data
On Fri, 30 Jan 2009 16:05:57 -0700, Dan Williams <dan.j.williams@...el.com> wrote:
> The conversion of atmel-mci to dma_request_channel missed the initialization
> of the channel dma_slave information. dma_request_channel, along with the
> filter_fn, find the channel with the proper capabilities, then it is up to the
> driver to update the dw_dma_chan with its slave data.
>
> Reported-by: Atsushi Nemoto <anemo@....ocn.ne.jp>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
Thanks. This patch disclose struct dw_dma_chan to its client. But
the struct seems too private for me. Maybe we need some generic
method to pass slave information? Any idea or plan?
---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists