linux-kernel - Re: [PATCH] atmel-mci: fix initialization of dma slave data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090131.235230.90118475.anemo@mba.ocn.ne.jp>
Date:	Sat, 31 Jan 2009 23:52:30 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	dan.j.williams@...el.com
Cc:	hskinnemoen@...el.com, kernel@...32linux.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atmel-mci: fix initialization of dma slave data

On Sat, 31 Jan 2009 21:06:51 +0900 (JST), Atsushi Nemoto <anemo@....ocn.ne.jp> wrote:
> > The conversion of atmel-mci to dma_request_channel missed the initialization
> > of the channel dma_slave information.  dma_request_channel, along with the
> > filter_fn, find the channel with the proper capabilities, then it is up to the
> > driver to update the dw_dma_chan with its slave data.
> > 
> > Reported-by: Atsushi Nemoto <anemo@....ocn.ne.jp>
> > Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> 
> Thanks.  This patch disclose struct dw_dma_chan to its client.  But
> the struct seems too private for me.  Maybe we need some generic
> method to pass slave information?  Any idea or plan?

Also, it seems too late to initialize dwc->dws after returning from
dma_request_channel().  The alloc_chan_resources routine of dw_dmac
driver needs dmc->dws and it is called from dma_request_channel() via
dma_chan_get().

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/