linux-kernel - Re: [PATCH] voyager: fix cpu bootmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200901312327.50684.rusty@rustcorp.com.au>
Date:	Sat, 31 Jan 2009 23:27:50 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	James Bottomley <James.Bottomley@...senpartnership.com>
Cc:	"linux-kernel" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] voyager: fix cpu bootmaps

On Saturday 31 January 2009 05:01:57 James Bottomley wrote:
> commit 98a79d6a50181ca1ecf7400eda01d5dc1bc0dbf0
> Author: Rusty Russell <rusty@...tcorp.com.au>
> Date:   Sat Dec 13 21:19:41 2008 +1030
> 
>     cpumask: centralize cpu_online_map and cpu_possible_map
> 
> Broke voyager largely because it currently initialises the
> possible_map by copying, which isn't possible in the new scheme.  Fix
> this by using init_cpu_possible() instead and tidy up other of the
> cpumask declarations which now have global variables.
> 
> Signed-off-by: James Bottomley <James.Bottomley@...senPartnership.com>
> ---
>  arch/x86/mach-voyager/voyager_smp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/mach-voyager/voyager_smp.c b/arch/x86/mach-voyager/voyager_smp.c
> index 9840b7e..dcc07d5 100644
> --- a/arch/x86/mach-voyager/voyager_smp.c
> +++ b/arch/x86/mach-voyager/voyager_smp.c
> @@ -378,7 +378,7 @@ void __init find_smp_config(void)
>  	cpus_addr(phys_cpu_present_map)[0] |=
>  	    voyager_extended_cmos_read(VOYAGER_PROCESSOR_PRESENT_MASK +
>  				       3) << 24;
> -	cpu_possible_map = phys_cpu_present_map;
> +	init_cpu_possible(&phys_cpu_present_map);
>  	printk("VOYAGER SMP: phys_cpu_present_map = 0x%lx\n",
>  	       cpus_addr(phys_cpu_present_map)[0]);
>  	/* Here we set up the VIC to enable SMP */

Strange, the assignment should still work, even though this new method is
preferred.

How do your patches normally get upstream?  I'd normally just fwd this to
Ingo...

Sorry I broke your platform...
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/