[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090201163440.GE3416@lst.de>
Date: Sun, 1 Feb 2009 17:34:40 +0100
From: Christoph Hellwig <hch@....de>
To: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
Cc: Christoph Hellwig <hch@....de>,
Alan Cox <alan@...rguk.ukuu.org.uk>, hpa@...or.com,
serue@...ibm.com, "David C. Hansen" <haveblue@...ibm.com>,
Containers <containers@...ts.osdl.org>,
linux-kernel@...r.kernel.org, sukadev@...ibm.com
Subject: Re: [RFC][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts
On Wed, Jan 28, 2009 at 10:45:47PM -0800, Sukadev Bhattiprolu wrote:
> + fsi = DEVPTS_SB(s);
> + opts = &fsi->mount_opts;
> + parse_mount_options(data, PARSE_REMOUNT, opts);
You could probably get rid of at least the fsi variable without making the
code less readable. Independent of these cosmetic bits the patch looks
good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists