linux-kernel - Re: [PATCH] net: variables reach -1, but 0 tested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090201.015805.28182673.davem@davemloft.net>
Date:	Sun, 01 Feb 2009 01:58:05 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dwalker@...o99.com
Cc:	roel.kluin@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: variables reach -1, but 0 tested

From: Daniel Walker <dwalker@...o99.com>
Date: Sat, 31 Jan 2009 12:35:12 -0800

> On Sat, 2009-01-31 at 11:36 +0100, Roel Kluin wrote:
> 
> >  
> > -	while (limit--) {
> > +	while (--limit) {
> >  		val = phy_read(phy, MII_BMCR);
> >  		if (val >= 0 && (val & BMCR_RESET) == 0)
> >  			break;
> 
> It looks like these are checked for <= to 0 , are these changes strictly
> nessesary?

Agreed.

I'd like to apply these fixes to net-2.6 but I can't if there
are spurious cases in here.

I'm dropping this patch for now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/