linux-kernel - Re: [PATCH] sched_rt: don't use first_cpu on cpumask created with cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200902012127.17150.rusty@rustcorp.com.au>
Date:	Sun, 1 Feb 2009 21:27:16 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, Mike Travis <travis@....com>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] sched_rt: don't use first_cpu on cpumask created with cpumask_and.

On Sunday 01 February 2009 00:19:47 Ingo Molnar wrote:
> 
> * Rusty Russell <rusty@...tcorp.com.au> wrote:
> 
> > Ingo, please apply to tip/urgent.
> > 
> > cpumask_and() only initializes nr_cpu_ids bits, so the (deprecated)
> > first_cpu() might find one of those uninitialized bits if nr_cpu_ids
> > is less than NR_CPUS (as it can be for CONFIG_CPUMASK_OFFSTACK).
> > 
> > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> > ---
> >  kernel/sched_rt.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Applied to tip/sched/urgent, thanks Rusty!
> 
> Also, Git sorted out the same-content merge with this commit in cpus4096 
> just fine:
> 
>   d38b223: cpumask: reduce stack usage in find_lowest_rq
> 
> (this commit is where you backported it from i suspect?)

No, this was a clean audit on current Linus' tree.  I wanted to make sure that
what Linus had worked...

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/