linux-kernel - Re: [PATCH] sched_rt: don't use first_cpu on cpumask created with cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090131134947.GA23973@elte.hu>
Date:	Sat, 31 Jan 2009 14:49:47 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	linux-kernel@...r.kernel.org, Mike Travis <travis@....com>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] sched_rt: don't use first_cpu on cpumask created with
	cpumask_and.


* Rusty Russell <rusty@...tcorp.com.au> wrote:

> Ingo, please apply to tip/urgent.
> 
> cpumask_and() only initializes nr_cpu_ids bits, so the (deprecated)
> first_cpu() might find one of those uninitialized bits if nr_cpu_ids
> is less than NR_CPUS (as it can be for CONFIG_CPUMASK_OFFSTACK).
> 
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> ---
>  kernel/sched_rt.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to tip/sched/urgent, thanks Rusty!

Also, Git sorted out the same-content merge with this commit in cpus4096 
just fine:

  d38b223: cpumask: reduce stack usage in find_lowest_rq

(this commit is where you backported it from i suspect?)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/