linux-kernel - Re: [PATCH 1/2] usb-serial : fix the nousb oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200902040912.40521.oliver@neukum.org>
Date:	Wed, 4 Feb 2009 09:12:39 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	Greg KH <greg@...ah.com>
Cc:	Dave Young <hidave.darkstar@...il.com>, wgreathouse@...a.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] usb-serial : fix the nousb oops

Am Wednesday 04 February 2009 00:58:14 schrieb Greg KH:
> On Mon, Feb 02, 2009 at 09:43:04AM +0800, Dave Young wrote:
 
> > No, it is not new thing.  usb serial drivers normally call
> > usb_serial_register first, then usb_register, usb_register will fail
> > due to "nousb" checking, but usb_serial_register no.
> 
> But as usb_register will fail, shouldn't they properly back out and no
> oopses happen?  This sounds like a simple fix to the drivers that are
> failing here, not changing the usb-serial core.

usb_register() can also fail for other reasons. There's no way you
can save drivers from needing to cleanly fail in that case.

> And this should only be an issue if you build your drivers into the
> kernel, right?

No, you can load drivers by other methods than udev.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/