linux-kernel - Re: [PATCH] x86: style fascism for xen assemblies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Feb 2009 18:34:30 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Tejun Heo <htejun@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Brian Gerst <brgerst@...il.com>,
	Xen-devel <xen-devel@...ts.xensource.com>, x86@...nel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: style fascism for xen assemblies


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Tejun Heo wrote:
>> Impact: style cleanup
>>
>> Make the following sytle cleanups.
>>
>> * drop unnecessary //#include from xen-asm_32.S
>>   
> Fine.
>> * compulsive adding of space after comma
>>   
> Fine.
>> * reformat multiline comments
>>   
>
> I don't really like what you've done here.  There are two problems:
>
>    * If you're going to convert comments of the form
>
>      /* This is a small comment which
>         happens to be longer than a line. */
>          
>
>      then you should convert it to full winged-style, rather than just
>      sticking '*' on the front of the second line.
>    * All the big block comments look crowded and cramped now, which
>      makes them harder to read and maintain.  All those '*'s are just
>      visual noise. (They make a bit more sense in C code to distinguish
>      comment from code, but asm code looks so different from comment
>      that they're not necessary here.)
>
> But Ingo's already pulled it, so I guess I'm stuck with it.

i pulled it and i already fixed all the proper winged style comments as 
well. Could you double-check the end result please?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/