linux-kernel - Re: [PATCH] x86: style fascism for xen assemblies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 06 Feb 2009 02:42:18 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Brian Gerst <brgerst@...il.com>,
	Xen-devel <xen-devel@...ts.xensource.com>, x86@...nel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: style fascism for xen assemblies

Hello,

Jeremy Fitzhardinge wrote:
> I don't really like what you've done here.  There are two problems:
> 
>    * If you're going to convert comments of the form
> 
>      /* This is a small comment which
>         happens to be longer than a line. */
>         
>      then you should convert it to full winged-style, rather than just
>      sticking '*' on the front of the second line.

I find fully winged style a bit excessive when a comment is in the
middle of code and not very long so I kind of just chose middleground.

>    * All the big block comments look crowded and cramped now, which
>      makes them harder to read and maintain.  All those '*'s are just
>      visual noise. (They make a bit more sense in C code to distinguish
>      comment from code, but asm code looks so different from comment
>      that they're not necessary here.)
> 
> But Ingo's already pulled it, so I guess I'm stuck with it.

Yeap, I really didn't expect everyone to be happy about it.  Style
cleanups always get ugly, so the fasicm joke on the subject.  Anyways,
if you feel strong against it, please feel free to change.  I
personally don't mind one way or the other.  I just wanted to make
things more consistent while at it.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/