linux-kernel - Re: [PATCH 3/7] PCI PM: Fix saving of device state in pci_legacy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1233795431.15714.13.camel@localhost>
Date:	Thu, 05 Feb 2009 11:57:11 +1100
From:	Michael Ellerman <michael@...erman.id.au>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Frans Pop <elendil@...net.nl>, rjw@...k.pl,
	jbarnes@...tuousgeek.org, linux-pm@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 3/7] PCI PM: Fix saving of device state in
 pci_legacy_suspend

On Thu, 2009-02-05 at 11:40 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2009-02-04 at 13:56 -0800, Linus Torvalds wrote:
> > 
> > On Thu, 5 Feb 2009, Benjamin Herrenschmidt wrote:
> > > 
> > > How so ? I've had such backtraces with no other info in my log...
> > 
> > _with_ that patch?
> > 
> > It very much replaces a warning with no further info with
> > 
> > +                       WARN_ONCE(pci_dev->current_state != prev,
> > +                               "PCI PM: Device state not saved by %pF\n",
> > +                               drv->suspend);
> > 
> > And notice the "%pF" and the 'drv->suspend': it should tell you exactly 
> > which suspend routine it was that messed up.
> 
> Yup, missed that change in the patch. In fact, I even missed the
> existence of a WARN_ONCE that takes those text arguments... baaaah. I
> suppose I should try to read more of lkml :-)

But don't expect to see them on powerpc, they never make it to the
console.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)