linux-kernel - Re: [PATCH 7/7] PCI PM: Let the core be more careful with respect to drivers using new framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1233796683.4612.37.camel@pasglop>
Date:	Thu, 05 Feb 2009 12:18:03 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PCI <linux-pci@...r.kernel.org>
Subject: Re: [PATCH 7/7] PCI PM: Let the core be more careful with respect
 to drivers using new framework


> I don't know about ppc, but on x86 the pcibios hook is only supposed to
> disable the device's interrupt link.

Right now on ppc, I may disable the clocks too, but then:

 - As soon as you have implemented the new scheme, I'll replace all that
with using the same hooks as ACPI so that won't be an issue anymore

 - Today, it's probably a non issue too because none of the devices for
which I have that sort of manual clock control also shares interrupts.

> Potentially, calling into the AML interpreter.

Right, but we are fixing that anyway with the noirq phase being AML safe
by no ? :-)
 
> When we implement the changes discussed in the "PCI PM: Restore standard
> config registers of all devices early" thread, that part will end up in
> suspend_noirq.

Yup.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/